@vietj can you please take a look? This is the fix for problems introduced by c684c42

Hi @tsegismont

I tested your branch but I don't get the real message, it seems that it still returns the ClosedConnectionException instead of the actual error.

Could you please confirm what I'm doing wrong?

    Vertx vertx = Vertx.vertx();
    PgConnectOptions connectOptions = new PgConnectOptions()
        .setPort(5432)
        .setHost("localhost")
        .setDatabase("postgres")
        .setUser("postgres")
        .setSslOptions(new ClientSSLOptions().setTrustAll(true))
        .setSslMode(SslMode.DISABLE)
        .setChannelBinding(io.vertx.pgclient.ChannelBinding.REQUIRE)
        .setPassword("123");

    PgConnection.connect(vertx, connectOptions)
        .onComplete(res -> {
          if (res.succeeded()) {
            System.out.println("Connected...");
          } else {
            System.out.println("Could not connect: " + res.cause().getMessage());
          }
        });
    vertx.close();

my branch does not aim to fix the bug we are currently observing in this issue, it aims first to get the exception handling flow correct from the NetSocket / SocketConnectionBase perspective before doing any other fix.

in particular : handleException should not close the socket in your patch because the socket will be closed by the code calling handleException, this is what I'd like to clarify and avoid.

@vietj please take another look

I had to make a special case in InitPgCommandMessage.java, because if we let the exception bubble up, then:

• the client tries to close the channel gracefully
• it sends a close command
• Postgres replies with a failure like "invalid state"
• the user gets the "invalid state failure" instead of the sasl failure

Nevertheless, I don't believe we have a way to close the connection abruptly like PostgreSQL expects:

If the frontend does not support the authentication method requested by the server, then it should immediately close the connection.

https://www.postgresql.org/docs/current/protocol-flow.html

I believe this would require changes in VertxConnection. Thoughts?

Well in fact, encoder.close() does exactly that 😓

your changes in InitPgCommandMessage makes sense to me and it looks more idiomatic to proceed this way.

another way would be to close the ChannelHandlerContext ?